Skip to content

Create PR template for release notes #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Conversation

sydneysugar
Copy link
Contributor

@sydneysugar sydneysugar commented Jun 19, 2023

Moved template to .github folder, but template is still in .md format, not .yaml.

External Release Notes

Test description 7 for enhancement label.

@sydneysugar sydneysugar requested a review from nrichers June 19, 2023 23:37
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull request, @sydneysugar! I made some suggested edits you can commit directly to your pull request. Let me know when you've made the changes and I will approve.

sydneysugar and others added 2 commits June 20, 2023 11:30
Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: Nik Richers <nik@validmind.ai>
@nrichers
Copy link
Collaborator

Moved template to .github folder, but template is still in .md format, not .yaml.

Looking at the docs, the format might actually be Markdown, not YAML, so your PR changes should work. We might have to merge the PR when ready to test.

sydneysugar and others added 4 commits June 20, 2023 11:36
Co-authored-by: Nik Richers <nik@validmind.ai>
Co-authored-by: Nik Richers <nik@validmind.ai>
Copy link
Collaborator

@nrichers nrichers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@nrichers nrichers merged commit 1a8ae2d into main Jun 20, 2023
@nrichers nrichers deleted the create-pull-request-template branch June 20, 2023 21:09
@sydneysugar sydneysugar added enhancement New feature or request bug Something isn't working labels Jun 29, 2023
@sydneysugar sydneysugar removed the bug Something isn't working label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants