🐛 payment channel opening blocks until transaction persists in database

Author: Robert Kiel

src/handlers/packet.js

@@ -35,9 +35,8 @@ module.exports = (node, options) => {
                 pull.once(packet.toBuffer()),
                 lp.encode(),
                 conn,
-                lp.decode({
-                    maxLength: Acknowledgement.SIZE
-                }),
+                lp.decode({ maxLength: Acknowledgement.SIZE }),
+                pull.filter((data) => data.length === Acknowledgement.SIZE),
                 pull.take(1),
                 pull.map(data => Acknowledgement.fromBuffer(data)),
                 pull.drain((data) => cb(null, data))
@@ -86,15 +85,17 @@ module.exports = (node, options) => {
                     currentValue: record.tx.value,
                     //index: tx.index,
                     tx: record.tx
-                }, channelId)
+                }, { channelId: channelId })
             }
         ], cb)
     }
 
     node.handle(PROTOCOL_STRING, (protocol, conn) => {
         pull(
             conn,
-            lp.decode(),
+            lp.decode({
+                maxLength: Packet.SIZE
+            }),
             pull.filter(data => data.length == Packet.SIZE),
             paramap((data, cb) => {
                 const packet = Packet.fromBuffer(data)

src/packet/index.js

@@ -114,7 +114,7 @@ class Packet {
                 return node.paymentChannels.setChannel({
                     currentValue: this.transaction.value,
                     index: this.transaction.index
-                }, channelId, cb)
+                }, { channelId: channelId }, cb)
             },
             (cb) => {
                 log(node.peerInfo.id, `Payment channel exists. Requested SHA256 pre-image of '${Challenge.deriveHashedKey(this.header.derivedSecret).toString('base64')}' is derivable.`)

src/paymentChannels/open.js

@@ -70,7 +70,7 @@ module.exports = (self) => (to, cb) => {
                 totalBalance: (new BN(restoreTx.value)).imuln(2).toBuffer('be', Transaction.VALUE_LENGTH)
             }
 
-            return self.setChannel(newRecord, (err) => {
+            return self.setChannel(newRecord, { sync: true }, (err) => {
                 if (err)
                     return cb(err)