Skip to content

test(isUUID): add tests for nil/max/all options #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Apr 8, 2025

Adds some tests to isUUID to cover the nil/max/all options, and a test for an invalid option. This makes codecov report a 100% project coverage again.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (791ef16) to head (8ab988d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #2549      +/-   ##
===========================================
+ Coverage   99.96%   100.00%   +0.03%     
===========================================
  Files         114       114              
  Lines        2535      2535              
  Branches      641       641              
===========================================
+ Hits         2534      2535       +1     
+ Partials        1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@WikiRik WikiRik mentioned this pull request Apr 8, 2025
4 tasks
@WikiRik WikiRik force-pushed the WikiRik/isUUID-tests branch from 5eef2e3 to ce29b50 Compare April 8, 2025 16:13
@WikiRik WikiRik marked this pull request as ready for review April 8, 2025 16:15
@WikiRik WikiRik requested review from profnandaa and rubiin April 8, 2025 16:15
@rubiin rubiin merged commit fde5ed5 into master Apr 8, 2025
10 checks passed
@profnandaa profnandaa deleted the WikiRik/isUUID-tests branch April 9, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants