Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI-Test: for #2442 --DON'T MERGE-- #2444

Closed
wants to merge 2 commits into from
Closed

CI-Test: for #2442 --DON'T MERGE-- #2444

wants to merge 2 commits into from

Conversation

pano9000
Copy link
Contributor

Just a quick PR with an failing test, to test #2442 (printing of arguments in error message) with the CI, as requested here
#2442 (review)

Please do not merge this -> I will remove the request after the tests again, THEN we can merge #2442

@pano9000
test(testFunctions): display stringified arguments in error message
e9a2f94 
this now shows the actual passed arguments,
instead of [Object object] in case a test with a options object fails
@pano9000
chore: add fake tests for temp CI test
1bf7ee0
@pano9000
Copy link
Contributor Author

CI is correctly printing
Error: validator.isDate("abc.def.hij", {"format":"MM.DD.YYYY","delimiters":["."],"strictMode":true}) failed but should have passed

@pano9000 pano9000 mentioned this pull request Aug 25, 2024
Merged
4 tasks
@pano9000 pano9000 marked this pull request as draft August 25, 2024 12:41
@pano9000
Copy link
Contributor Author

closing this now, as #2442 is now merged

@pano9000 pano9000 closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pano9000