Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isURL): add max_allowed_length option #2439

Merged
merged 1 commit into from
Aug 15, 2024
Merged

feat(isURL): add max_allowed_length option #2439

merged 1 commit into from
Aug 15, 2024

Conversation

pinkiesky
Copy link
Contributor

This PR enhances the isURL validator by introducing an option to customize the maximum allowed URL length, replacing the previously hardcoded limit.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin requested a review from profnandaa August 14, 2024 18:11
profnandaa
profnandaa approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contrib! 🎉

@profnandaa profnandaa merged commit 542cfba into validatorjs:master Aug 15, 2024
10 checks passed
@a9261020 a9261020 mentioned this pull request Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pinkiesky @profnandaa @rubiin