Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Updated the readme and added tests for validator of Marshall Islands country #2367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

poswalsameer
Copy link

This PR solves my previous issue of not updating the readme and I have added tests too for validation of the mobile number

Fixes #1761

Checklist

  • [Yes] PR contains only changes related; no stray files, etc.
  • [Yes] README updated (where applicable)
  • [Yes] Tests written (where applicable)
  • [Yes] References provided in PR (where applicable)

@rubiin
Copy link
Member

rubiin commented May 12, 2024

@poswalsameer could you fix the failed tests.
Also there are two PRs for the same thing #2365

@rubiin rubiin added 🧹 needs-update For PRs that need to be updated before landing duplicate Duplicate issue labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate issue 🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile Phone validations - For The First Time Contributors
2 participants