Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isUUID): support uuid v7 #2345

Merged
merged 1 commit into from
Apr 25, 2024
Merged

feat(isUUID): support uuid v7 #2345

merged 1 commit into from
Apr 25, 2024

Conversation

ruscon
Copy link
Contributor

@ruscon ruscon commented Dec 9, 2023

closes #2344

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (b261c36) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format looks good, please add some tests in https://github.com/validatorjs/validator.js/blob/master/test/validators.test.js

You can ignore the failure of codecov/project. That is not due to your changes

@ruscon
Copy link
Contributor Author

ruscon commented Dec 11, 2023

@WikiRik Done, waiting for you.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@rubiin rubiin added the ready-to-land For PRs that are reviewed and ready to be landed label Dec 27, 2023
@Chrisp1tv
Copy link

Hello @ruscon @WikiRik, is there something preventing this PR from being merged? 🙂

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

And sorry for the delayed response. Will go into the next release.

@profnandaa profnandaa merged commit 6d5c52a into validatorjs:master Apr 25, 2024
8 of 9 checks passed
@ruscon ruscon deleted the patch-1 branch April 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support uuid v7 for isUUID
7 participants