-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ulid): ULID validation #2294
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2294 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 110 108 -2
Lines 2510 2455 -55
Branches 633 620 -13
===========================================
- Hits 2510 2454 -56
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pls fix the merge conflict and we should be good to go.
@profnandaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added validation for ULID (Universally Unique Lexicographically Sortable Identifier).
Read more details on ULID in github:ulid/spec
ULID Generator and validations on https://ulid.page
Checklist