fix(isPassportNumber): fix regex Azerbaijan #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the updated Azerbaijan passport validation: See issue: validatorjs#2274
Update isPassportNumber.js
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2284 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 107 107
Lines 2454 2454
Branches 619 619
=======================================
Hits 2453 2453
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Awesome, thanks! Needed this |
amaliacatalina
changed the title
Name changed. |
|
Hello, @WikiRik what do we need to do to approve this one? |
ssm0801
approved these changes
Sep 27, 2023
|
Hello! This has still not been approved |
|
how is this still not merged yet? |
rubiin
approved these changes
Mar 28, 2024
profnandaa
approved these changes
Apr 25, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(isPassportNumber): regex fix for Azerbaijan
Fixed regex for Azerbaijan isPassportNumber
https://irb.gc.ca/en/country-information/rir/Pages/index.aspx?doc=455354&pls=1
"According to Keesing, the passport number is 8 digits preceded by a letter (ibid.)"
Checklist