-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new validator: isMailtoURI, validate the mailto link URI format #2188
Conversation
Codecov ReportBase: 100.00% // Head: 99.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2188 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 106 107 +1
Lines 2348 2391 +43
Branches 593 605 +12
===========================================
+ Hits 2348 2390 +42
- Partials 0 1 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Could you provide some use cases for this new validator? When would an user need to input such a mailto URI? Or when would you want to check this coming from another system? I think this would be a too niche use case for this project |
For projects like website builder, it would be great to provide the user some feedback about what they are trying to achieve and whether it's valid or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
Added a new validation method for validating the
mailto:
link URI. Where it'll validate the URI format and also the email provided inside the appropriate query params.Here is the format of a mailto link URI
mailto:to(optional, comma-separated emails)?cc=(optional, comma-separated emails)&bb=(optional, comma-separated emails)&subject=(optional)&body=(optional)
Some links:
https://mailtrap.io/blog/mailto-links-explained/
https://en.wikipedia.org/wiki/Mailto
Checklist