build(devDeps): Update rollup and babel to latest packages #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changed `rollup-plugin-babel` (unmaintained) to `@rollup/plugin-babel` (maintained)
* options have been renamed in rollup * babelHelpers: 'bundled' added explicitly to avoid rollup nagging about it not being set explicitly
|
looks like I overlooked, that rollup later also switched to to requiring a more modern Node installation, which is why all these tests are failing :-( |
|
What might be a better approach is to build in Node 18 (latest LTS), upload the resulting artifact and download that to be used in the other Node versions. That way we can use new code/dependencies internally. I'm not that sure if maintainers will merge this or that they'll prefer work on #1869 |
|
Lets follow this up on #2401 as it also has eslint changes |
|
I'll close this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the devDependencies in package.json to the latest version, where possible.
This also made some changes necessary in the
browser-build.js, as a few of the options have been renamed since v0.48https://gist.github.com/Rich-Harris/d472c50732dab03efeb37472b08a3f32
I skipped updating
eslint, as they are dropping Node 6 support since v5, while this project seems to still want to have support for Node 6, so for now we are stuck with eslint v4.Fixes #2123
Checklist
[ ] README updated (where applicable)[ ] Tests written (where applicable)