fix(isMobilePhone): Fix el-GR validation - Add missing ranges + correctly exclude certain ranges #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, looks like I based my branch off a wrong branch, let me try to fix that, the README.md should not have been part of this PR EDIT: ok, fixed my previous mistake, sorry about that! |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2112 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pano9000
force-pushed
the
fix_el-gr_isMobilePhone
branch
from
35d28ab
to
c8ca440
Compare
update the RegExp to correctly match (and exclude) number ranges as per official ITU numbering plan: https://web.archive.org/web/20221205170159/https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000550002PDFE.pdf fixes validatorjs#2111
pano9000
force-pushed
the
fix_el-gr_isMobilePhone
branch
from
c8ca440
to
d897415
Compare
braaar
approved these changes
Dec 7, 2022
WikiRik
approved these changes
Dec 13, 2022
rubiin
approved these changes
Jan 21, 2023
rubiin
added
ready-to-land
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous RegExp for el-GR had some flaws and was
a) missing some number ranges (like
685, etc.)b) not excluding certain number ranges (i.e. overly permissive RegExp), like
692or696References:
Official Greek numbering plan on the ITU website, last updated in 2021:
https://web.archive.org/web/20221205170159/https://www.itu.int/dms_pub/itu-t/oth/02/02/T02020000550002PDFE.pdf
See #2111 for some more in-depth info
This fixes #2111
Checklist
Thank you!
[ ] README updated (where applicable)