Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): Added regex for Mongolia mn-MN #1993

Merged
merged 1 commit into from
Jun 30, 2022
Merged

feat(isMobilePhone): Added regex for Mongolia mn-MN #1993

merged 1 commit into from
Jun 30, 2022

Conversation

rksp25
Copy link
Contributor

@rksp25 rksp25 commented Jun 29, 2022

Added regex for Mongolia mn-MN

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1993 (61ee147) into master (cfcf911) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1993   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          103       103           
  Lines         2097      2097           
  Branches       473       473           
=========================================
  Hits          2097      2097           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf911...61ee147. Read the comment docs.

@profnandaa
Copy link
Member

Thanks for your contrib on this. This is the very first mn-Mn locale one, you could also do more others!

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@profnandaa profnandaa merged commit 73098eb into validatorjs:master Jun 30, 2022
@rksp25
Copy link
Contributor Author

rksp25 commented Jul 5, 2022

Hi @profnandaa i have raised one more for country BENIN: #1997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants