Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isMobilePhone): add Iran locale, ir-IR #1922

Merged
merged 2 commits into from
Jul 19, 2022
Merged

feat(isMobilePhone): add Iran locale, ir-IR #1922

merged 2 commits into from
Jul 19, 2022

Conversation

ArashST79
Copy link
Contributor

Iran phone number added to list with some tests
also readme is updated

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1922 (c194bda) into master (f055c11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1922   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...c194bda. Read the comment docs.

rubiin
rubiin previously approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

bennetfabian
bennetfabian previously approved these changes Mar 25, 2022
View reviewed changes
profnandaa
profnandaa previously approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib 🎉

// And sorry for the delay in reviewing this.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 22, 2022
@profnandaa profnandaa changed the title Add Iran phone number feat(isMobilePhone): add Iran locale, ir-IR Apr 22, 2022
@rubiin rubiin dismissed stale reviews from profnandaa, bennetfabian, and themself via 222cacc July 19, 2022 16:49
@rubiin rubiin merged commit c193fe5 into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
This was referenced May 25, 2024
Open
Open
@ceconcarlsen ceconcarlsen mentioned this pull request May 31, 2024
Open
@IT21275210 IT21275210 mentioned this pull request Jun 8, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Aug 3, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@KOTTAGENVH KOTTAGENVH mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubiin rubiin rubiin approved these changes

@bennetfabian bennetfabian bennetfabian left review comments

@profnandaa profnandaa profnandaa left review comments

Assignees
No one assigned
Labels
🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArashST79 @rubiin @profnandaa @bennetfabian