Skip to content

Conversation

islasjuanp
Copy link
Contributor

Add support for Venezuela phone numbers in isMobilePhone validator.
Closes: #1720

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1734 (2f605e7) into master (5b04cc5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1734   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         2005      2005           
  Branches       452       452           
=========================================
  Hits          2005      2005           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b04cc5...2f605e7. Read the comment docs.

@islasjuanp islasjuanp force-pushed the adding-venezuela-phone-number-validation branch from 214fdcf to 2f605e7 Compare September 20, 2021 19:00
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for the PR @islasjuanp 🎉

@tux-tn tux-tn added the ready-to-land For PRs that are reviewed and ready to be landed label Sep 20, 2021
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit c899b31 into validatorjs:master Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: venezuela phone number +58
5 participants