Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isAlpha, isAlphanumeric): Adds Hindi (hi-IN) language support addition to isAlpha & isAlphanumeric #1716

Merged
merged 2 commits into from
Sep 26, 2021

Conversation

mikr13
Copy link
Contributor

@mikr13 mikr13 commented Aug 22, 2021

This commit introduces Indian Hindi language support (hi-IN) into isAlpha and isAlphanumeric methods.

Character List

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

This commit introduces Indian Hindi language support (hi-IN)

*
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1716 (f6506cd) into master (8c4b3b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1716   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          101       101           
  Lines         2005      2005           
  Branches       452       452           
=========================================
  Hits          2005      2005           
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4b3b3...f6506cd. Read the comment docs.

@mikr13 mikr13 changed the title Adds Hindi (hi-IN) language support addition to isAlpha & isAlphanumeric feat(isAlpha, isAlphanumeric): Adds Hindi (hi-IN) language support addition to isAlpha & isAlphanumeric Aug 22, 2021
@ezkemboi
Copy link
Member

Doing a code review here

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you for your PR and sorry for the late review

@tux-tn tux-tn added 🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed labels Sep 25, 2021
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit b069167 into validatorjs:master Sep 26, 2021
@mikr13
Copy link
Contributor Author

mikr13 commented Sep 29, 2021

Thanks for the merge! 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants