feat(isLicensePlate): add support for Swedish license plates #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1665 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2072 2073 +1
Branches 472 472
=========================================
+ Hits 2072 2073 +1
Continue to review full report at Codecov.
|
profnandaa
previously approved these changes
Jul 16, 2021
profnandaa
added
the
mc-to-land
|
@profnandaa Fixed the merge conflict |
tux-tn
requested changes
Sep 27, 2021
There was a problem hiding this comment.
Hello @elmaxe and thank you for your PR. Can you please check my comments below?
In addition to that i have two more general feedbacks:
- Multiple white-spaces are considered a valid license plate. You should probably trim your string before passing it to the regex validation in order to prevent that.
- According to the wikipedia page of swedish license plates, a plate can't end with the
Ocharacter to prevent it from being confused with0, i don't see that exception in your regex, am i wrong?
Fair!
Interestingly this is not on the Swedish wikipedia page, but it is correct (source) |
tux-tn
approved these changes
Dec 6, 2021
tux-tn
added
ready-to-land
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Swedish license plates.
Checklist