-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isMobileNumber(phone,"vi-VN"): support new telco numbers 087 #1575
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 100 100
Lines 1796 1796
=========================================
Hits 1796 1796
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the tests too for completeness? After that, we should be good to go.
Thanks, I added tests for the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contrib! 🎉
* chore: prevent git from ignoring src/index.js file * chore: remove unused exclusion from nyc config * chore: replace travis-ci with github actions * chore: fix issue with github workflow config * chore: fix condition for coverage generation and sending * chore: treat node version as int * docs: replace travis with github actions badge * chore: add npm publish github action * chore: remove auto-generated files * chore: improve github actions styles * chore: use correct repo url to prevent unecessary redirect * chore: lint package.json file * chore: add new line at end of file * feat(isMobilePhone): update de-CH, add fr-CH, it-CH locales (#1554) * fix(isMobilePhone): update de-CH locale (#1549) feat(isMobilePhone): add fr-CH locale (#1549) feat(isMobilePhone): add it-CH locale (#1549) * fix(isMobilePhone): update de-CH, fr-CH and it-CH locale in validator.min.js(#1549) * fix(isMobilePhone): update fr-CH and it-CH locale aliases (#1549) Co-authored-by: Ashutosh Kumar <kumar.ashutosh@siemens.com> * feat(isLicensePlate): new validator 🎉 (#1495) * Added isLicensePlate check with german locale * de-LI (Liechtenstein) validator * Added albanian number plates * reversed changes in index.js * reversed changes in index.js * Refactored de-DE into one big regex, expanded tests fot de-DE * added pt-PT locale * Fixed coverage problem * feat(isLicensePlate): clean build * coverage is now 100% * Update README.md * Update README.md * fix(isTaxID): fix el-GR locale when checksum is 10 (#1529) Add correct tax identifier to demonstrate issue and fix. Thanks to: Panos Papadopoulos * feat(isMobileNumber): add support new telco numbers for VN locale (#1575) * Support new VN mobile phone 087 (https://didong.itelecom.vn/) * Add test for new telco number Co-authored-by: Kyle Dinh <kyle@Kyles-Mac-mini.telio> * chore: set a fixed ubuntu version instead of relying on latest Co-authored-by: Ashutosh Kumar <dinfekted@users.noreply.github.com> Co-authored-by: Ashutosh Kumar <kumar.ashutosh@siemens.com> Co-authored-by: Michael Firlus <michael@4lus.de> Co-authored-by: Diomidis Spinellis <dds@aueb.gr> Co-authored-by: Kyle Dinh <kyled7@users.noreply.github.com> Co-authored-by: Kyle Dinh <kyle@Kyles-Mac-mini.telio>
We have new telco (https://didong.itelecom.vn/) with number 087***
Update library to support this number as valid VN phone number.
Checklist