Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): Added locales for several european countries #1492

Merged
merged 10 commits into from
Oct 22, 2020

Conversation

firlus
Copy link
Contributor

@firlus firlus commented Oct 18, 2020

Currently contains: San Marino, Luxembourg, Albania and Andorra.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #1492 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1492   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1276     1277    +1     
=======================================
+ Hits         1275     1276    +1     
  Misses          1        1           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c8047...fd8d7df. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib @firlus -- and thanks for picking up another issue after the other closed PR :)

Just one change to be made and we should be good to go. Could you update the README with the new locales?

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Oct 21, 2020
@firlus
Copy link
Contributor Author

firlus commented Oct 21, 2020

Updated the README.md. The merge conflict comes from the es-HN locale that was pushed to master in the mean time. I also included it in my branch, so we should be good to go with the README.md version from my branch. @profnandaa

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants