-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isMobilePhone): Added locales for several european countries #1492
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 96 96
Lines 1276 1277 +1
=======================================
+ Hits 1275 1276 +1
Misses 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contrib @firlus -- and thanks for picking up another issue after the other closed PR :)
Just one change to be made and we should be good to go. Could you update the README with the new locales?
Updated the README.md. The merge conflict comes from the es-HN locale that was pushed to master in the mean time. I also included it in my branch, so we should be good to go with the README.md version from my branch. @profnandaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Currently contains: San Marino, Luxembourg, Albania and Andorra.
Checklist