Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add th-TH locale for isAlpha #1481

Merged
merged 11 commits into from
Oct 14, 2020
Merged

Add th-TH locale for isAlpha #1481

merged 11 commits into from
Oct 14, 2020

Conversation

ipiranhaa
Copy link
Contributor

{{ Add th-TH locale for isAlpha }}

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #1481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          96       96           
  Lines        1276     1276           
=======================================
  Hits         1275     1275           
  Misses          1        1           
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba862a...cf16cf6. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib 🎉 Just one comment.

index.js Outdated Show resolved Hide resolved
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@profnandaa
Copy link
Member

Please fix the merge conflict and we should be good to go.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants