maintenance: plans for a new release + suggestions #2125
Comments
|
Sure, great feedback, thank you.
I will consult with other maintainers and see how we can do that.
Prof. Nandaa was the one who used to help on new releases
…On Thu, Dec 8, 2022 at 12:39 PM Panagiotis Papadopoulos < ***@***.***> wrote:
Hi all,
I wonder if there currently is any "path" towards the next release?
It has been a year since the last release, and I don't seem to see any
path towards a new release, but an ever growing backlog of PRs of small to
big size, some of which will bring a lot of improvements, but are currently
a bit a pain to be merged, e.g. the effort to split the tests into separate
files, or the effort to introduce an "options" object to different
validators.
So my suggestion going forward would be:
1.
Focus first on getting a new release ready of what we already have in
master + maybe check the open PRs for some of the easy/simple "fixes" and
get these in as well - this will include fixing "blocking" issues like
#2123 <#2123>
2.
Afterwards identify the "easy" "feat" and "refactor" PRs, e.g. the
mostly the ones that add features to existing validators (e.g. I can see a
ton of isMobilePhone PRs) - afterwards do another release
3.
Work on getting these "bigger" PRs in
Pinging the current maintainers, what do you think?
@profnandaa <https://github.com/profnandaa>, @tux-tn
<https://github.com/tux-tn>, @rubiin <https://github.com/rubiin>,
@ezkemboi <https://github.com/ezkemboi>
If you need any help, with that, kindly let me know, happy to help here as
much as I can.
—
Reply to this email directly, view it on GitHub
<#2125>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVWPH7VPDL7TBEKCTVX77LWMGUDZANCNFSM6AAAAAASX5AIDE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Regards,
Ezrqn Kemboi. <http://www.ezrqnkemboi.dev>
Software Engineer | Innovator | Open Source Enthusiast
|
|
Sounds like a good plan. I'm also happy to help with initial reviews and identifying in which categories PRs fall. I think that @braaar is also willing to help and maybe @pixelbucket-dev as well (although I believe he is more interested in working on #1874 and other issues coming out of that) |
|
I'm happy to help out. I agree that it's important to get an overview of what we want to include in releases. I think we've had a pretty tight focus on backwards compatibility recently, so we can definitely do a minor version release with a lot of new features and fixes before considering a major release. To me it seems like commit messages are a bit of a wild west right now, which must make it a bit harder to put together release notes. Maybe we could use a github action to enforce PR titles/commit messages, like this |
Recently yes, but there have been quite some PRs merged over the last year so it might be safer to just do a major release. But that's also something to consider when making the CHANGELOG |
I agree here, for release note management we could consider squash and merge to have predictable merge commits. |
Yes, in general I am happy to help. However, I am quite new to the project, so I don't have the historic overview (yet) to judge all of the above. Let me know if I can assist in something specific, e.g. review or category identification :). |
|
Apologies, I've been quite slow on my end in following up with the reviews but I should be getting back to form now. Yes, reviews are highly welcome! It makes the maintainers work easier, knowing that a couple of more eyes have had a look at the PRs. So, I covet your help here @WikiRik @braaar @pixelbucket-dev and anyone else. That said, we should be able to get out a release by mid Jan 2023. Will be nice to have the holiday season remain quiet. Thanks for your suggestions @pano9000, we'll take that to account. |
|
NB: while reviewing, those with merge conflicts on README.md, the authors don't need to change anything, I will fix those during merging and still retain the contribution credits for the authors. |
|
Hi all, just wanted to cautiously ask about any update on this topic? |
|
We should do a release by end of next week. I'll just pick whatever will be ready by then; then the subsequent PRs can follow for the next release, scheduling for March 2023. Any help on the reviews will still be appreciated. |
|
I have updates around 10-20 prs with labels. All prs with |
|
I'm ready to make the first release now. Thanks so much @pano9000 for the great work on the PRs and also helping review + triages! Quick one, could you fix the merge conflicts on your PRs only - https://github.com/validatorjs/validator.js/issues?q=is%3Aopen+label%3Amc-to-land+author%3Apano9000 will love to add those in the release. And then I will handle the remaining ones as I do the release. |
|
@profnandaa thanks, I am on it, and should done at the latest by tomorrow afternoon (CET) |
|
other smaller PR that could be a potential candidate for merging: |
|
@pano9000 -- thanks! I think we are good to go now. I'll work ont he remaining mc-to-land's and stage the release tomorrow. |
|
This coming release is going to be a HUGE one! I want to be very careful not to mess up anything. I will really appreciate if you folks can help skim over the previous commits just to make sure there's nothing wrong that slipped our previous reviews. Here is the prep PR - #2166 I'm yet to complete on about 5 clean-ups and then prep the release notes. |
profnandaa
changed the title
|
@profnandaa thanks, I will take a look at it tonight and report back. |
|
UPDATE: almost done with the clean-ups, 2 more PRs to go - #2164 // https://github.com/validatorjs/validator.js/pulls?q=is%3Apr+is%3Aopen+label%3Amc-to-land |
|
Pushing by 1 more day. |
|
I just checked, and from what I can tell, it looks good to me |
|
Finally releasing today evening, release notes now ready! |
|
We did it, thanks folks! 🎉 |
|
@ALL congrats on the new release! :-) |
Hi all,
I wonder if there currently is any "path" towards the next release?
It has been a year since the last release, and I don't seem to see any path towards a new release, but an ever growing backlog of PRs of small to big size, some of which will bring a lot of improvements, but are currently a bit a pain to be merged, e.g. the effort to split the tests into separate files, or the effort to introduce an "options" object to different validators.
So my suggestion going forward would be:
Focus first on getting a new release ready of what we already have in master + maybe check the open PRs for some of the easy/simple "fixes" and get these in as well - this will include fixing "blocking" issues like Dependency Issue: Installation via npm fails #2123
Afterwards identify the "easy" "feat" and "refactor" PRs, e.g. the mostly the ones that add features to existing validators (e.g. I can see a ton of isMobilePhone PRs) - afterwards do another release
Work on getting these "bigger" PRs in
Pinging the current maintainers, what do you think?
@profnandaa, @tux-tn, @rubiin, @ezkemboi
If you need any help, with that, kindly let me know, happy to help here as much as I can.
The text was updated successfully, but these errors were encountered: