Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isURL returning false for a URL with plus(es) in it #2106

Open
FizzBuzz791 opened this issue Dec 1, 2022 · 4 comments
Open

isURL returning false for a URL with plus(es) in it #2106

FizzBuzz791 opened this issue Dec 1, 2022 · 4 comments

Comments

@FizzBuzz791
Copy link

Describe the bug
A URL like https://my-url.com/Validator+Test/This+Is+A+File+Name.mp4 is returning false when passed to isURL. (Happy to provide a real URL if you can't replicate with this example).

Additional context
Validator.js version: 13.7.0
Node.js version:14.19.2
OS platform: [windows, linux, macOS, etc] Linux

@pano9000
Copy link
Contributor

pano9000 commented Dec 4, 2022

Hello,

For me https://my-url.com/Validator+Test/This+Is+A+File+Name.mp4 returns true, as expected, so I can't replicate this.
(tested with Node 16 though).
Maybe it could be worth to check with your real URL?

@FizzBuzz791
Copy link
Author

Ah, that'll teach me to fake the URL, perhaps it's because the + is in a param? Like https://my-url.com/test?source=This+Is+A+File+Name.mp4. I don't think there's anything else that's special about the URL...

@pano9000
Copy link
Contributor

pano9000 commented Dec 6, 2022

Even with this new URL, I can't seem to get the validator to return false, it still returns true for me

@pano9000
Copy link
Contributor

@FizzBuzz791 can you confirm if you still have that issue? as mentioned above I could not reproduce with your examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants