Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should isURL host_whitelist ignore other requirements? #1743

Closed
theroncross opened this issue Oct 1, 2021 · 3 comments
Closed

Should isURL host_whitelist ignore other requirements? #1743

theroncross opened this issue Oct 1, 2021 · 3 comments
Labels
🐛 bug

Comments

@theroncross
Copy link

Describe the bug
The host_whitelist option for isURL requires the input to pass all other requirements, which seems to defeat the purpose of a whitelist.

Examples
Validator.isURL('localhost', { host_whitelist: ['localhost'] }) => false

Additional context
Validator.js version: 13.6
Node.js version: 14.7.6
OS platform: linux
@fedeci
Copy link
Contributor

fedeci commented Oct 1, 2021

Similar to #1731, I can address this one

@theroncross
Copy link
Author

Sorry about that - didn't come up with a search for host_whitelist. Thanks all. Let me know if I can help.

@theroncross
Copy link
Author

closing in favor of #1731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theroncross @fedeci