isURL return true for e-mail

[mjancarik]

Describe the bug
Hi,

What is the correct behaviour for isURL function when I give e-mail address? I would expect that return false.

Examples
An example from the Node REPL:

Welcome to Node.js v14.16.0.
Type ".help" for more information.
> var validator = require('validator');
undefined
> validator.isURL('user@example.com');
true
> 

Additional context
Validator.js version: 13.6.0
Node.js version: 14.16.0
OS platform: macOS

[brybrophy]

I was going to submit a PR to fix this, but then I saw these tests...

validator.js/test/validators.js

Lines 672 to 688 in 907bb07

	it('should accept urls containing authentication information', () => {
	test({
	validator: 'isURL',
	args: [{ disallow_auth: false }],
	valid: [
	'user@example.com',
	'user:@example.com',
	'user:password@example.com',
	],
	invalid: [
	'user:user:password@example.com',
	'@example.com',
	':@example.com',
	':example.com',
	],
	});
	});

It seems that you can set the disallow_auth option to true and it will fail validation on an email.

[mjancarik]

Hi,

Thank you. I will try it. I would expect default behaviour with disallow_auth to true.

[raghavbk]

@ezkemboi can i work on this issue

[ezkemboi]

@raghavbk if you have a PR, please do it and we will review it. Thanks.

[Jassi10000-zz]

@mjancarik
Buddy can you tell one thing

user@example.com : This will treated as an email due to the presence of " @ " in it , so I think its bound to return true to this

[ffxsam]

In no way is an email address a URL, as someone claimed in an issue.

mailto:xyz@xyz.net is a URL/URI, but xyz@xyz.net is not. This should be considered a bug.

[Yuniac]

Well, till someone figure out which way is the correct way, doing this works for everyone else:

validator.isURL('xyz@xyz.net', { disallow_auth: true }); // false