Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lebanese phone numbers are not correctly validated #1410

Closed
Mageek627 opened this issue Aug 16, 2020 · 2 comments
Closed

Lebanese phone numbers are not correctly validated #1410

Mageek627 opened this issue Aug 16, 2020 · 2 comments

Comments

@Mageek627
Copy link

Describe the bug
The isMobilePhone validator doesn't work for (at least some) Lebanese phone numbers.

Examples
With isMobilePhone('any', { strictMode: true }), this phone number: +96170072968 (which is the first example on https://en.wikipedia.org/wiki/Telephone_numbers_in_Lebanon) appears as invalid, but it's actually valid.

Possible solution
I would suggest using the google-libphonenumber library as dependency, as it seems to be very popular and very accurate for phone number validation.

Additional context
Validator.js version: 13.1.1
Node.js version: 14.8.0
OS platform: macOS 10.15.6

@rubiin
Copy link
Member

rubiin commented Aug 19, 2020

@profnandaa i think i can work on the mobilenumber validation feature plus bug requests including this one

@tux-tn
Copy link
Member

tux-tn commented Apr 25, 2021

Closed in #1473

@tux-tn tux-tn closed this as completed Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants