Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isIBAN(str) validation fail on EG, SV, ... IBAN-s #1392

Closed
viliamzigo opened this issue Jul 25, 2020 · 5 comments
Closed

isIBAN(str) validation fail on EG, SV, ... IBAN-s #1392

viliamzigo opened this issue Jul 25, 2020 · 5 comments
Labels
🐛 bug

Comments

@viliamzigo
Copy link

Describe the bug
IBAN from countries listed bellow are not validated correctly.

  • Egypt
  • El Salvador
  • Malta
  • Saint Lucia
  • Seychelles

Examples

Example IBANs:

  • SC52BAHL01031234567890123456USD
  • LC14BOSL123456789012345678901234
  • MT31MALT01100000000000000000123
  • SV43ACAT00000000000000123123
  • EG800002000156789012345180002

Additional context
Validator.js version: 13.1.1
Node.js version: v14.5.0
@heanzyzabala
Copy link
Contributor

I would like to work on this. Thanks!

@heanzyzabala
Copy link
Contributor

Hi, I create a PR for this: #1394

@profnandaa
Copy link
Member

profnandaa commented Jul 27, 2020 •
edited
Loading

@heanzyzabala -- thanks! does the PR close all the issues listed here?

@heanzyzabala
Copy link
Contributor

@profnandaa Yes. Thanks!

@profnandaa
Copy link
Member

closed by #1394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@profnandaa @heanzyzabala @viliamzigo