Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Israel (IL) postal code can be 5 or 7 digits - not just 5 digits #1365

Closed
AtomicBorg opened this issue Jun 26, 2020 · 3 comments · Fixed by #1367
Closed

Israel (IL) postal code can be 5 or 7 digits - not just 5 digits #1365

AtomicBorg opened this issue Jun 26, 2020 · 3 comments · Fixed by #1367
Labels

Comments

@AtomicBorg
Copy link

isPostalCode only allows 5 digit postal codes for Israel (IL)

  • Currently Israel officially uses 7 digit postal codes but also still accepts 5 digit codes in practice

I'd make the PR directly but I do not have permission to create Pull Requests on this repository.

I propose modifying the existing line for IL to:
IL: /^(\d{5}|\d{7})$/,

Background on Israel postal codes; fundamentally, although officially switching to a 7 digit system in 2012 and supposedly deprecating 5 digit codes in 2013, 5 digit postal codes are still commonly used

Various references:
https://worldpostalcode.com/israel/
https://en.youbianku.com/Israel
https://www.reference.com/business-finance/zip-code-israel-168914627f8cae6
https://en.wikipedia.org/wiki/Postal_codes_in_Israel

@profnandaa
Copy link
Member

Oh sure, please do a PR.

@rubiin
Copy link
Member

rubiin commented Jun 28, 2020

if no ones taking it, i will do pr asap

@AtomicBorg
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants