Skip to content

proto: add support for indentation and nested lists #9399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jun 5, 2025

Description

Fixes #1610

Depends on #9007

  • Added CSS for nested lists from Quill core
    • Copied mostly without changing, including not working RTL styles (see below)
  • Modified logic for keyboard Tab bindings

TODO:

  • Fix RTL styles (right now lists in RTL are broken)
    • There are styles for .ql-direction-rtl but these are related to Quill toolbar 'direction': 'rtl' that we don't use
    • Need to update to use :host([dir='rtl']) instead, also keep in mind the .ql-align-right classes
  • Add toolbar buttons for increase / decrease indentation
    • Corrresponding Lumo icons needed
  • Add tests for ordered / unordered lists
    • Test that indentation works, preferably using sendKeys(). We can rely on .ql-indent classes in unit tests, maybe can also consider snapshots
    • Test that correct htmlValue is returned: <ol> for ordered and <ul> for bullet lists
  • Add visual tests for list indentation

Type of change

  • Feature

Note

Styles are using counter-set CSS property supported since Safari 17.2

Copy link

sonarqubecloud bot commented Jun 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rich-text-editor] Add support for indentation and nested lists
1 participant