File tree 4 files changed +14
-12
lines changed 4 files changed +14
-12
lines changed Original file line number Diff line number Diff line change @@ -103,16 +103,17 @@ export declare class MenuBarMixinClass {
103
103
* #### Disabled items
104
104
*
105
105
* When an item is disabled, it prevents any user interaction with it, such as
106
- * focusing, clicking, or opening a sub-menu.
106
+ * focusing, clicking, opening a sub-menu, etc. The item is also removed from the
107
+ * tab order, which may negatively impact accessibility.
107
108
*
108
109
* To improve accessibility, disabled root-level items (menu bar buttons) can be
109
110
* made focusable so that screen readers can reach and properly announce them to
110
- * users. Other interactions such as clicks remain disabled . This behavior is
111
- * currently experimental and can be enabled with the feature flag:
111
+ * users, while still preventing clicks. This is currently available as an
112
+ * experimental enhancement that can be enabled with the following feature flag:
112
113
*
113
114
* ```
114
115
* // Set before any menu bar is attached to the DOM.
115
- * window.Vaadin.featureFlags.focusableDisabledComponents = true
116
+ * window.Vaadin.featureFlags.accessibleDisabledButtons = true;
116
117
* ```
117
118
*/
118
119
items : MenuBarItem [ ] ;
Original file line number Diff line number Diff line change @@ -81,16 +81,17 @@ export const MenuBarMixin = (superClass) =>
81
81
* #### Disabled items
82
82
*
83
83
* When an item is disabled, it prevents any user interaction with it, such as
84
- * focusing, clicking, or opening a sub-menu.
84
+ * focusing, clicking, opening a sub-menu, etc. The item is also removed from the
85
+ * tab order, which may negatively impact accessibility.
85
86
*
86
87
* To improve accessibility, disabled root-level items (menu bar buttons) can be
87
88
* made focusable so that screen readers can reach and properly announce them to
88
- * users. Other interactions such as clicks remain disabled . This behavior is
89
- * currently experimental and can be enabled with the feature flag:
89
+ * users, while still preventing clicks. This is currently available as an
90
+ * experimental enhancement that can be enabled with the following feature flag:
90
91
*
91
92
* ```
92
93
* // Set before any menu bar is attached to the DOM.
93
- * window.Vaadin.featureFlags.focusableDisabledComponents = true
94
+ * window.Vaadin.featureFlags.accessibleDisabledButtons = true;
94
95
* ```
95
96
*
96
97
* @type {!Array<!MenuBarItem> }
Original file line number Diff line number Diff line change @@ -7,11 +7,11 @@ describe('focusable disabled buttons', () => {
7
7
8
8
before ( ( ) => {
9
9
window . Vaadin . featureFlags ??= { } ;
10
- window . Vaadin . featureFlags . focusableDisabledComponents = true ;
10
+ window . Vaadin . featureFlags . accessibleDisabledButtons = true ;
11
11
} ) ;
12
12
13
13
after ( ( ) => {
14
- window . Vaadin . featureFlags . focusableDisabledComponents = false ;
14
+ window . Vaadin . featureFlags . accessibleDisabledButtons = false ;
15
15
} ) ;
16
16
17
17
beforeEach ( async ( ) => {
Original file line number Diff line number Diff line change @@ -355,11 +355,11 @@ describe('menu-bar with tooltip', () => {
355
355
describe ( 'focusable disabled button' , ( ) => {
356
356
before ( ( ) => {
357
357
window . Vaadin . featureFlags ??= { } ;
358
- window . Vaadin . featureFlags . focusableDisabledComponents = true ;
358
+ window . Vaadin . featureFlags . accessibleDisabledButtons = true ;
359
359
} ) ;
360
360
361
361
after ( ( ) => {
362
- window . Vaadin . featureFlags . focusableDisabledComponents = false ;
362
+ window . Vaadin . featureFlags . accessibleDisabledButtons = false ;
363
363
} ) ;
364
364
365
365
beforeEach ( async ( ) => {
You can’t perform that action at this time.
0 commit comments