fix: Attach rendered component (#1967)

Fixes #1966

Author: TatuLund

vaadin-testbench-unit-junit5/src/test/java/com/vaadin/flow/component/grid/BasicGridTesterTest.java

@@ -9,6 +9,8 @@
 package com.vaadin.flow.component.grid;
 
 import com.vaadin.flow.component.Component;
+import com.vaadin.flow.component.button.Button;
+import com.vaadin.flow.component.notification.Notification;
 import com.vaadin.flow.router.RouteConfiguration;
 import com.vaadin.testbench.unit.UIUnitTest;
 import com.vaadin.testbench.unit.ViewPackages;
@@ -165,6 +167,17 @@ void basicGrid_doubleClick() {
 
     }
 
+    @Test
+    void getCellComponent_columnByKey_canClickAButton() {
+        final Component cellComponent = test(view.basicGrid).getCellComponent(1,
+                BasicGridView.BUTTON_KEY);
+        Assertions.assertInstanceOf(Button.class, cellComponent);
+        var button = (Button) cellComponent;
+        test(button).click();
+        var notification = $(Notification.class).last();
+        Assertions.assertEquals("Clicked!", test(notification).getText());       
+    }
+
     @Test
     void getCellComponent_columnByKey_returnsInstantiatedComponent() {
         final Component cellComponent = test(view.basicGrid).getCellComponent(1,
@@ -206,12 +219,12 @@ void basicGrid_reorderColumns() {
 
         // person 1
         Assertions.assertEquals("Jorma",
-                test(view.basicGrid).getCellText(0, 3));
-        Assertions.assertEquals("46", test(view.basicGrid).getCellText(0, 2));
+                test(view.basicGrid).getCellText(0, 4));
+        Assertions.assertEquals("46", test(view.basicGrid).getCellText(0, 3));
 
         // person 2
-        Assertions.assertEquals("Maya", test(view.basicGrid).getCellText(1, 3));
-        Assertions.assertEquals("18", test(view.basicGrid).getCellText(1, 2));
+        Assertions.assertEquals("Maya", test(view.basicGrid).getCellText(1, 4));
+        Assertions.assertEquals("18", test(view.basicGrid).getCellText(1, 3));
     }
 
     @Test

vaadin-testbench-unit-junit5/src/test/java/com/vaadin/flow/component/grid/BasicGridView.java

@@ -10,6 +10,8 @@
 
 import com.vaadin.flow.component.Component;
 import com.vaadin.flow.component.HasComponents;
+import com.vaadin.flow.component.button.Button;
+import com.vaadin.flow.component.notification.Notification;
 import com.vaadin.flow.component.Tag;
 import com.vaadin.flow.data.renderer.ComponentRenderer;
 import com.vaadin.flow.data.renderer.LitRenderer;
@@ -24,6 +26,7 @@ public class BasicGridView extends Component implements HasComponents {
     static final String AGE_KEY = "Age";
     static final String SUBSCRIBER_KEY = "Subscriber";
     static final String DECEASED_KEY = "Deceased";
+    static final String BUTTON_KEY = "Button";
 
     final Grid<Person> basicGrid;
     final Person person1;
@@ -48,6 +51,9 @@ public BasicGridView() {
         basicGrid.addColumn(deceasedRenderer())
                 .setKey(DECEASED_KEY)
                 .setHeader("Deceased");
+        basicGrid.addComponentColumn(person -> new Button("Click", e -> Notification.show("Clicked!")))
+                .setKey(BUTTON_KEY)
+                .setHeader("Button");
 
         add(basicGrid);
 

vaadin-testbench-unit-shared/src/main/java/com/vaadin/flow/component/grid/GridTester.java

@@ -307,8 +307,12 @@ public Component getCellComponent(int row, String columnName) {
     private Component getRendererItem(int row, Grid.Column<Y> yColumn) {
         if (yColumn.getRenderer() instanceof ComponentRenderer) {
             final Y item = getRow(row);
-            return ((ComponentRenderer<?, Y>) yColumn.getRenderer())
+            var component = ((ComponentRenderer<?, Y>) yColumn.getRenderer())
                     .createComponent(item);
+            if (component != null) {
+                getComponent().getElement().appendChild(component.getElement());
+            }
+            return component;
         }
         throw new IllegalArgumentException(
                 "Target column doesn't have a ComponentRenderer.");