Skip to content

Commit 2a1cff2

Browse files
committed
revert using extensions in any module
It fixes the issue that Maven try to resolve the plugin before the reactor build even starts. Maven needs to load extensions during the project model building phase, which happens before any module is compiled.
1 parent 97dd89d commit 2a1cff2

File tree

2 files changed

+53
-6
lines changed

2 files changed

+53
-6
lines changed

vaadin-platform-test/pom-dev.xml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -106,11 +106,6 @@
106106
<skipNexusStagingDeployMojo>true</skipNexusStagingDeployMojo>
107107
</configuration>
108108
</plugin>
109-
<plugin>
110-
<groupId>com.vaadin</groupId>
111-
<artifactId>vaadin-maven-plugin</artifactId>
112-
<extensions>true</extensions>
113-
</plugin>
114109
</plugins>
115110
</build>
116111

@@ -200,6 +195,17 @@
200195
</execution>
201196
</executions>
202197
</plugin>
198+
<plugin>
199+
<groupId>com.vaadin</groupId>
200+
<artifactId>vaadin-maven-plugin</artifactId>
201+
<executions>
202+
<execution>
203+
<goals>
204+
<goal>prepare-frontend</goal>
205+
</goals>
206+
</execution>
207+
</executions>
208+
</plugin>
203209
</plugins>
204210
</build>
205211
</profile>

vaadin-platform-test/pom.xml

Lines changed: 42 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,13 @@
164164
<plugin>
165165
<groupId>com.vaadin</groupId>
166166
<artifactId>vaadin-maven-plugin</artifactId>
167-
<extensions>true</extensions>
167+
<executions>
168+
<execution>
169+
<goals>
170+
<goal>prepare-frontend</goal>
171+
</goals>
172+
</execution>
173+
</executions>
168174
</plugin>
169175
</plugins>
170176
</build>
@@ -247,6 +253,17 @@
247253
</execution>
248254
</executions>
249255
</plugin>
256+
<plugin>
257+
<groupId>com.vaadin</groupId>
258+
<artifactId>vaadin-maven-plugin</artifactId>
259+
<executions>
260+
<execution>
261+
<goals>
262+
<goal>prepare-frontend</goal>
263+
</goals>
264+
</execution>
265+
</executions>
266+
</plugin>
250267
<plugin>
251268
<artifactId>maven-antrun-plugin</artifactId>
252269
<version>3.0.0</version>
@@ -266,5 +283,29 @@
266283
</build>
267284
</profile>
268285

286+
<profile>
287+
<!-- Production mode is activated using -Pproduction -->
288+
<id>production</id>
289+
<activation>
290+
<property>
291+
<name>vaadin.productionMode</name>
292+
</property>
293+
</activation>
294+
<build>
295+
<plugins>
296+
<plugin>
297+
<groupId>com.vaadin</groupId>
298+
<artifactId>vaadin-maven-plugin</artifactId>
299+
<executions>
300+
<execution>
301+
<goals>
302+
<goal>build-frontend</goal>
303+
</goals>
304+
</execution>
305+
</executions>
306+
</plugin>
307+
</plugins>
308+
</build>
309+
</profile>
269310
</profiles>
270311
</project>

0 commit comments

Comments
 (0)