Skip to content

chore!: Change supported Node from 18 to 20 #20669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024
Merged

chore!: Change supported Node from 18 to 20 #20669

merged 2 commits into from
Dec 11, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 11, 2024

Node 20 is the active LTS version for Node.

Node 18 will be end of life soon and new libraries like React 19 support Node 20+

Node 20 is the active LTS version for Node.

Node 18 will be end of life soon and new libraries like React 19 support Node 20+
Copy link

github-actions bot commented Dec 11, 2024

Test Results

1 158 files  ±0  1 158 suites  ±0   1h 34m 17s ⏱️ + 7m 40s
7 520 tests ±0  7 467 ✅ ±0  53 💤 ±0  0 ❌ ±0 
7 874 runs  +7  7 812 ✅ +7  62 💤 ±0  0 ❌ ±0 

Results for commit 4b79f00. ± Comparison against base commit a784ea1.

♻️ This comment has been updated with latest results.

Copy link

@Artur- Artur- requested a review from mshabarov December 11, 2024 09:51
@mshabarov mshabarov merged commit c7a0714 into main Dec 11, 2024
26 checks passed
@mshabarov mshabarov deleted the node20-1 branch December 11, 2024 11:10
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.rc2 and is also targeting the upcoming stable 24.7.0 version.

@PhilippWendler
Copy link

Is it intended that this raised the required NPM version from 8.6 to 9.6 and not to something like 9.0?

Also I note that https://vaadin.com/docs/latest/compatibility still lists Node 18.

@mshabarov
Copy link
Contributor

@PhilippWendler thanks for the comment!

About npm 9.0 I'm not sure. Node 20.0 was shipped with npm 9.6, 9.0 may work, but I'd stick with 9.6.
Here is the update for compatibility page vaadin/docs#4257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants