PWA Icon not used/overwritten

[simasch]

Description of the bug

I’ve migrated an app to Vaadin 25 and now the favicon is no longer generated correctly.

I see the blue with with circle default icon instead of my icon.

Security config is correct and the file is 512x512 and stored in /src/resources/META-INF/resources/icons/icon.png

According to @mcollovati this must be a bug:

During the frontend build, TaskGeneratePWAIcons correctly generates PWA icons based on the project PNG in META-INF/resources/icons/icon.png, but then they are overwritten by TaskPrepareProdBundle with the icons from the default prod bundle.

It is easily reproducible with the skeleton-starter-flow-spring project by just running a production build (mvn package). In dev mode I see the correct icon, but running the app from the production fat JAR, the default one is shown.

The same issue appears to be present also in 24.9.

I guess this does not happen when a custom bundle is required.

Expected behavior

The custom icon should be used

Minimal reproducible example

It is easily reproducible with the skeleton-starter-flow-spring project by just running a production build

Versions

• Vaadin / Flow version: 25 (but also 24.9)

[mcollovati]

I guess the easiest fix could be to remove the generated PWA icons from the prod bundle, since TaskGeneratePWAIcons will anyway generate them again even if a custom icon is not provided in the project.

[simasch]

Unfortunately, that's not possible because the build runs in a pipeline.

For m,e this is currently a blocker because I cannot go to production without the correct icon.

[mcollovati]

Sorry, I was a bit unclear. I meant removing them from vaadin-prod-bundle artifact

[simasch]

How can I do that?

[mcollovati]

Unfortunately, it's something to be done in the Vaadin platform repo, not a workaround that can be applied in a project.

[mcollovati]

A workaround could be to rename the icon and update the @PWA annotation accordingly.

[simasch]

Ah sure! Thanks for the tip and happy new year!

[mcollovati]

Ah sure! Thanks for the tip and happy new year!

You're welcome. Best wishes to you too!