Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported MPR wrapped legacy components lose styles #19446

Open
Tracked by #5012
OlliTietavainenVaadin opened this issue May 24, 2024 · 1 comment
Open
Tracked by #5012

Exported MPR wrapped legacy components lose styles #19446

OlliTietavainenVaadin opened this issue May 24, 2024 · 1 comment
Labels

Comments

@OlliTietavainenVaadin
Copy link
Member

Description of the bug

When I have a V8 component with MPR's LegacyWrapper, I can use it without problems in a Flow view. If I try to use the same component in a React view via WebComponentExporter, the component appears and reacts to events as expected but doesn't have any styles.

Expected behavior

Legacy styles should be shown

Minimal reproducible example

https://github.com/vaadin/hackathon-24-4/tree/olli

Versions

  • Vaadin / Flow version: 24.4.beta4
  • Java version: 21
  • OS version: Windows 11
  • Browser version (if applicable): Chrome (latest)
  • Application Server (if applicable): Spring Boot
  • IDE (if applicable): IntelliJ Idea
@mshabarov
Copy link
Contributor

This issue isn't in newly introduced ReactAdapterElement or related API, but in between Embedded Flow and MPR features (i.e. WebComponentExporter and LegacyWrapper).

I can confirm that if I take Flow 24.3 branch and add a legacy components into exported web-component, I'll get no styling either.

@mshabarov mshabarov removed their assignment May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔖 Normal Priority (P2)
Development

No branches or pull requests

2 participants