Skip to content

Commit

Permalink
[postmortem] add ScopeInfo and Context types
Browse files Browse the repository at this point in the history
The metadata introduced in this patch will be useful for postmortem
tools to inspect Contexts and ScopeInfos (see
nodejs/llnode#211).

R=bmeurer@google.com, yangguo@google.com

Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95
Reviewed-on: https://chromium-review.googlesource.com/1153858
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54768}
  • Loading branch information
Matheus Marchini authored and Commit Bot committed Jul 28, 2018
1 parent ae76bb4 commit 09bca09
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,7 @@ action("postmortem-metadata") {
"src/objects/js-regexp-string-iterator.h",
"src/objects/map.h",
"src/objects/map-inl.h",
"src/objects/scope-info.h",
"src/objects/script.h",
"src/objects/script-inl.h",
"src/objects/shared-function-info.h",
Expand Down
5 changes: 4 additions & 1 deletion tools/gen-postmortem-metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@
{ 'name': 'APIObjectType', 'value': 'JS_API_OBJECT_TYPE' },
{ 'name': 'SpecialAPIObjectType', 'value': 'JS_SPECIAL_API_OBJECT_TYPE' },

{ 'name': 'FirstContextType', 'value': 'FIRST_CONTEXT_TYPE' },
{ 'name': 'LastContextType', 'value': 'LAST_CONTEXT_TYPE' },

{ 'name': 'IsNotStringMask', 'value': 'kIsNotStringMask' },
{ 'name': 'StringTag', 'value': 'kStringTag' },

Expand Down Expand Up @@ -282,7 +285,7 @@
expected_classes = [
'ConsString', 'FixedArray', 'HeapNumber', 'JSArray', 'JSFunction',
'JSObject', 'JSRegExp', 'JSValue', 'Map', 'Oddball', 'Script',
'SeqOneByteString', 'SharedFunctionInfo'
'SeqOneByteString', 'SharedFunctionInfo', 'ScopeInfo'
];


Expand Down

0 comments on commit 09bca09

Please sign in to comment.