Skip to content

Commit df04786

Browse files
isheludkopthier
authored andcommitted
Don't use soon-to-be-deprecated V8 Api (#182)
Namely v8::FunctionCallbackInfo::Holder(), one should use This() method instead. See https://crrev.com/c/5444829 for details.
1 parent 68373a6 commit df04786

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -925,9 +925,9 @@ class from C++.
925925
The JavaScript object can be accessed as a `v8::Local<v8::Object>` by using
926926
`self->object()`, given a `BaseObject` named `self`.
927927
928-
Accessing a `BaseObject` from a `v8::Local<v8::Object>` (frequently that is
929-
`args.This()` in a [binding function][]) can be done using
930-
the `Unwrap<T>(obj)` function, where `T` is a subclass of `BaseObject`.
928+
Accessing a `BaseObject` from a `v8::Local<v8::Object>` (that is `args.This()`
929+
in a [binding function][]) can be done using the `Unwrap<T>(obj)` function,
930+
where `T` is a subclass of `BaseObject`.
931931
A helper for this is the `ASSIGN_OR_RETURN_UNWRAP` macro that returns from the
932932
current function if unwrapping fails (typically that means that the `BaseObject`
933933
has been deleted earlier).

0 commit comments

Comments
 (0)