Adapt tests for increased TypedArray sizes (#161)

V8 will increase the maximum TypedArray size in
https://crrev.com/c/4872536; this CL adapts the tests to allow for that.

Tests that hard-code smaller sizes or are already tested in V8 are
removed; one test is adapted to not rely on a specific limit.

Author: victorgomes

test/parallel/test-buffer-alloc.js

@@ -9,13 +9,16 @@ const {
   kMaxLength,
 } = require('buffer');
 
+<<<<<<< HEAD
 // Verify the maximum Uint8Array size. There is no concrete limit by spec. The
 // internal limits should be updated if this fails.
 assert.throws(
   () => new Uint8Array(kMaxLength + 1),
   { message: `Invalid typed array length: ${kMaxLength + 1}` },
 );
 
+=======
+>>>>>>> b3e1523f34 (Adapt tests for increased TypedArray sizes (#161))
 const b = Buffer.allocUnsafe(1024);
 assert.strictEqual(b.length, 1024);
 

test/parallel/test-buffer-tostring-rangeerror.js

@@ -18,26 +18,23 @@ const {
   },
 } = require('buffer');
 
-const len = MAX_STRING_LENGTH + 1;
-const message = {
-  code: 'ERR_STRING_TOO_LONG',
-  name: 'Error',
-};
-
-function test(getBuffer) {
-  let buf;
+// Find the maximum supported buffer length.
+let limit = 1 << 31; // 2GB
+while (true) {
   try {
-    buf = getBuffer();
+    Buffer(limit);
+    limit *= 2;
   } catch (e) {
-    // If the buffer allocation fails, we skip the test.
-    if (e.code === 'ERR_MEMORY_ALLOCATION_FAILED' || /Array buffer allocation failed/.test(e.message)) {
-      return;
-    }
+    break;
   }
-  assert.throws(() => { buf.toString('utf8'); }, message);
 }
 
-test(() => Buffer(len));
-test(() => Buffer.alloc(len));
-test(() => Buffer.allocUnsafe(len));
-test(() => Buffer.allocUnsafeSlow(len));
+const message = {
+  code: 'ERR_STRING_TOO_LONG',
+  name: 'Error',
+};
+assert.throws(() => Buffer(limit).toString('utf8'), message);
+assert.throws(() => SlowBuffer(limit).toString('utf8'), message);
+assert.throws(() => Buffer.alloc(limit).toString('utf8'), message);
+assert.throws(() => Buffer.allocUnsafe(limit).toString('utf8'), message);
+assert.throws(() => Buffer.allocUnsafeSlow(limit).toString('utf8'), message);