Skip to content

Commit 8d04bd7

Browse files
authored
Fix implementation of ContextifyContext::PropertySetterCallback() (#194)
V8 doesn not allow returning arbitrary values from the interceptor setter callbacks, only a boolean return value is allowed. Since default return value is "true" it's not even necessary to set the return value on a successful path. See https://crbug.com/348660658 for details.
1 parent 286ed38 commit 8d04bd7

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/node_contextify.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,6 @@ Intercepted ContextifyContext::PropertySetterCallback(
567567
// property
568568
if (desc_obj->HasOwnProperty(context, env->get_string()).FromMaybe(false) ||
569569
desc_obj->HasOwnProperty(context, env->set_string()).FromMaybe(false)) {
570-
args.GetReturnValue().Set(value);
571570
return Intercepted::kYes;
572571
}
573572
}

0 commit comments

Comments
 (0)