Skip to content

Commit 364a819

Browse files
isheludkopthier
authored andcommitted
Don't use soon-to-be-deprecated V8 Api (#182)
Namely v8::FunctionCallbackInfo::Holder(), one should use This() method instead. See https://crrev.com/c/5444829 for details.
1 parent 687f97c commit 364a819

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -906,9 +906,9 @@ class from C++.
906906
The JavaScript object can be accessed as a `v8::Local<v8::Object>` by using
907907
`self->object()`, given a `BaseObject` named `self`.
908908
909-
Accessing a `BaseObject` from a `v8::Local<v8::Object>` (frequently that is
910-
`args.This()` in a [binding function][]) can be done using
911-
the `Unwrap<T>(obj)` function, where `T` is a subclass of `BaseObject`.
909+
Accessing a `BaseObject` from a `v8::Local<v8::Object>` (that is `args.This()`
910+
in a [binding function][]) can be done using the `Unwrap<T>(obj)` function,
911+
where `T` is a subclass of `BaseObject`.
912912
A helper for this is the `ASSIGN_OR_RETURN_UNWRAP` macro that returns from the
913913
current function if unwrapping fails (typically that means that the `BaseObject`
914914
has been deleted earlier).

0 commit comments

Comments
 (0)