Skip to content

Commit 31d762e

Browse files
isheludkovictorgomes
authored andcommitted
Don't use soon-to-be-deprecated V8 Api (#182)
Namely v8::FunctionCallbackInfo::Holder(), one should use This() method instead. See https://crrev.com/c/5444829 for details.
1 parent 9506c1f commit 31d762e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -835,9 +835,9 @@ class from C++.
835835
The JavaScript object can be accessed as a `v8::Local<v8::Object>` by using
836836
`self->object()`, given a `BaseObject` named `self`.
837837

838-
Accessing a `BaseObject` from a `v8::Local<v8::Object>` (frequently that is
839-
`args.This()` in a [binding function][]) can be done using
840-
the `Unwrap<T>(obj)` function, where `T` is a subclass of `BaseObject`.
838+
Accessing a `BaseObject` from a `v8::Local<v8::Object>` (that is `args.This()`
839+
in a [binding function][]) can be done using the `Unwrap<T>(obj)` function,
840+
where `T` is a subclass of `BaseObject`.
841841
A helper for this is the `ASSIGN_OR_RETURN_UNWRAP` macro that returns from the
842842
current function if unwrapping fails (typically that means that the `BaseObject`
843843
has been deleted earlier).

0 commit comments

Comments
 (0)