Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

This should solve the issue: #10250 where for large files split can run out of memory. I was able to use the built in integration test support to limit the resources that the test has to mock a scenario where the file is larger than the available memory to trigger the conditions for the bug.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 14, 2026

Merging this PR will degrade performance by 20.58%

❌ 1 regressed benchmark
✅ 140 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation split_number_chunks 289.5 µs 364.5 µs -20.58%

Comparing ChrisDryden:fix-split-number-memory-issue (da74374) with main (f7b5f8f)2

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (450e7cf) during the generation of this report, so f7b5f8f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant