Skip to content

Commit c2d3fed

Browse files
authored
fix: apply stricter typing to the v* signatures (#831)
1 parent 913e958 commit c2d3fed

File tree

6 files changed

+4
-28
lines changed

6 files changed

+4
-28
lines changed

src/v1.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ type V1State = {
2525
const _state: V1State = {};
2626

2727
function v1(options?: Version1Options, buf?: undefined, offset?: number): string;
28-
function v1(options?: Version1Options, buf?: Uint8Array, offset?: number): Uint8Array;
28+
function v1(options: Version1Options | undefined, buf: Uint8Array, offset?: number): Uint8Array;
2929
function v1(options?: Version1Options, buf?: Uint8Array, offset?: number): UUIDTypes {
3030
let bytes: Uint8Array;
3131

src/v3.ts

-12
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,6 @@ import v35, { DNS, URL } from './v35.js';
44

55
export { DNS, URL } from './v35.js';
66

7-
function v3(
8-
value: string | Uint8Array,
9-
namespace: UUIDTypes,
10-
buf?: undefined,
11-
offset?: number
12-
): string;
13-
function v3(
14-
value: string | Uint8Array,
15-
namespace: UUIDTypes,
16-
buf?: Uint8Array,
17-
offset?: number
18-
): Uint8Array;
197
function v3(value: string | Uint8Array, namespace: UUIDTypes, buf?: Uint8Array, offset?: number) {
208
return v35(0x30, md5, value, namespace, buf, offset);
219
}

src/v4.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import rng from './rng.js';
44
import { unsafeStringify } from './stringify.js';
55

66
function v4(options?: Version4Options, buf?: undefined, offset?: number): string;
7-
function v4(options?: Version4Options, buf?: Uint8Array, offset?: number): Uint8Array;
7+
function v4(options: Version4Options | undefined, buf: Uint8Array, offset?: number): Uint8Array;
88
function v4(options?: Version4Options, buf?: Uint8Array, offset?: number): UUIDTypes {
99
if (native.randomUUID && !buf && !options) {
1010
return native.randomUUID();

src/v5.ts

-12
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,6 @@ import v35, { DNS, URL } from './v35.js';
44

55
export { DNS, URL } from './v35.js';
66

7-
function v5(
8-
value: string | Uint8Array,
9-
namespace: UUIDTypes,
10-
buf?: undefined,
11-
offset?: number
12-
): string;
13-
function v5(
14-
value: string | Uint8Array,
15-
namespace: UUIDTypes,
16-
buf?: Uint8Array,
17-
offset?: number
18-
): Uint8Array;
197
function v5(value: string | Uint8Array, namespace: UUIDTypes, buf?: Uint8Array, offset?: number) {
208
return v35(0x50, sha1, value, namespace, buf, offset);
219
}

src/v6.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import v1 from './v1.js';
44
import v1ToV6 from './v1ToV6.js';
55

66
function v6(options?: Version6Options, buf?: undefined, offset?: number): string;
7-
function v6(options?: Version6Options, buf?: Uint8Array, offset?: number): Uint8Array;
7+
function v6(options: Version6Options | undefined, buf: Uint8Array, offset?: number): Uint8Array;
88
function v6(options?: Version6Options, buf?: Uint8Array, offset?: number): UUIDTypes {
99
options ??= {};
1010
offset ??= 0;

src/v7.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ type V7State = {
1010
const _state: V7State = {};
1111

1212
function v7(options?: Version7Options, buf?: undefined, offset?: number): string;
13-
function v7(options?: Version7Options, buf?: Uint8Array, offset?: number): Uint8Array;
13+
function v7(options: Version7Options | undefined, buf: Uint8Array, offset?: number): Uint8Array;
1414
function v7(options?: Version7Options, buf?: Uint8Array, offset?: number): UUIDTypes {
1515
let bytes: Uint8Array;
1616

0 commit comments

Comments
 (0)