Feature/make compile with godot 4.3 rc3 (#659)

* feat: make cpp code compile with godot 4.3-RC3

* feat: regenerate api for 4.3-RC3

* chore: bump godot version in CI

* Fix MoltenVK build

* feat: update to godot 4.3-stable

* fix: use AttachCurrentThreadAsDaemon while godot did not fix WorkerThreadPool

* fix(ci): set new MoltenVK location

* fix(ci): use maximize-build-space to reduce occupied disk space for linux

---------

Co-authored-by: Ced Naru <cednaru.dev@gmail.com>

Author: piiertho

.github/workflows/assemble_ios.yml

@@ -13,7 +13,7 @@ concurrency:
 
 jobs:
   create-ios-export-template-universal:
-    runs-on: macos-latest
+    runs-on: macos-13 #MoltenVK is built differently if using macos-14+
     name: Assemble iOS export template
     steps:
       - name: Clone Godot Engine
@@ -22,8 +22,12 @@ jobs:
           repository: godotengine/godot
           ref: ${{ inputs.godot-version }}
 
+      # Python must be kept below 3.12
+      #https://github.com/KhronosGroup/MoltenVK/blob/3b9e335fe8fc8a72cf6099acbd54128889445c0a/.github/workflows/CI.yml#L44
       - name: Setup python and scons
         uses: ./.github/actions/godot-deps
+        with:
+          python-version: 3.11
 
       - name: Download ios export template binaries
         uses: actions/download-artifact@v4
@@ -36,7 +40,7 @@ jobs:
         with:
           repository: KhronosGroup/MoltenVK
           path: MoltenVk
-          ref: v1.2.6
+          ref: v1.2.10
 
       - name: Build MoltenVK
         run: |
@@ -45,7 +49,7 @@ jobs:
       - name: Create iOS template app
         run: |
           cp -r misc/dist/ios_xcode .
-          cp -r MoltenVK/Package/Release/MoltenVK/MoltenVK.xcframework ios_xcode/
+          cp -r MoltenVK/Package/Release/MoltenVK/dynamic/MoltenVK.xcframework ios_xcode/
           cp libgodot.ios.template_release.arm64.a ios_xcode/libgodot.ios.release.xcframework/ios-arm64/libgodot.a
           cp libgodot.ios.template_debug.arm64.a ios_xcode/libgodot.ios.debug.xcframework/ios-arm64/libgodot.a
           mv ios_xcode/ ios/ && cd ios/

.github/workflows/build_linux.yml

@@ -43,6 +43,9 @@ jobs:
             sconsflags: ''
 
     steps:
+      - name: Maximize build disk space
+        uses: easimon/maximize-build-space@v10
+
       - name: Clone Godot Engine
         uses: actions/checkout@v4
         with:

.github/workflows/trigger_dev.yml

@@ -66,7 +66,7 @@ jobs:
       - run: |
           echo "Setup done"
     outputs: # defined here explicitly, so it only needs to be defined here. All other workflows can just reference it
-      godot-version: "4.2.2-stable"
+      godot-version: "4.3-stable"
       jvm-version: "17"
 
   build-jvm:

.github/workflows/trigger_on_pull_request.yml

@@ -14,8 +14,8 @@ jobs:
       - run: |
           echo "Setup done"
     outputs: # defined here explicitly, so it only needs to be defined here. All other workflows can just reference it
-      godot-kotlin-jvm-version: "0.9.1-4.2.2"
-      godot-version: "4.2.2-stable"
+      godot-kotlin-jvm-version: "0.9.1-4.3.0"
+      godot-version: "4.3-stable"
       jvm-version: "17"
 
   build-jvm:

.github/workflows/trigger_on_push_master.yml

@@ -19,8 +19,8 @@ jobs:
       - run: |
           echo "Setup done"
     outputs: # defined here explicitly, so it only needs to be defined here. All other workflows can just reference it
-      godot-kotlin-jvm-version: "0.9.1-4.2.2"
-      godot-version: "4.2.2-stable"
+      godot-kotlin-jvm-version: "0.9.1-4.3.0"
+      godot-version: "4.3-stable"
       jvm-version: "17"
 
   build-jvm:

.github/workflows/trigger_on_tag.yml

@@ -24,8 +24,8 @@ jobs:
       - run: |
           echo "Setup done"
     outputs: # defined here explicitly, so it only needs to be defined here. All other workflows can just reference it
-      godot-kotlin-jvm-version: "0.9.1-4.2.2"
-      godot-version: "4.2.2-stable"
+      godot-kotlin-jvm-version: "0.9.1-4.3.0"
+      godot-version: "4.3-stable"
       jvm-version: "17"
 
   build-jvm:

docs/src/doc/contribution/setup.md

@@ -15,10 +15,10 @@ Make sure that Java is installed and its `PATH` set in your system as well (**at
 Once you have all the necessary dependencies, proceed to do the following:
 
 1. Clone Godot's repository with the stable tag you want to develop for. Notice that the branch tag must be
-aligned to the current binding's version (e.g., current version `0.9.1-4.2.2`, we need Godot at `4.2.2` version).
+aligned to the current binding's version (e.g., current version `0.9.1-4.3.0`, we need Godot at `4.3.0` version).
 
 ```bash
-git clone git@github.com:godotengine/godot.git --branch 4.2.2-stable --recursive
+git clone git@github.com:godotengine/godot.git --branch 4.3-stable --recursive
 ```
 
 2. In the `godot` directory, run the following command:

docs/src/doc/user-guide/versioning.md

@@ -1,7 +1,7 @@
 The module uses semantic versioning for its own versions but adds a suffix for the supported Godot version:
 
-Full version: `0.9.1-4.2.2`
+Full version: `0.9.1-4.3.0`
 
 Module Version: `0.9.1`
 
-Supported Godot Version: `4.2.2`
+Supported Godot Version: `4.3.0`