Enable dbms_output before calling ut_runner.run #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jgebal
reviewed
Oct 24, 2017
| * @param bufferLen the buffer length | ||
| */ | ||
| public static void enableDBMSOutput(Connection conn, int bufferLen) { | ||
| try (CallableStatement call = conn.prepareCall("BEGIN dbms_output.enable(?); END;")) { |
There was a problem hiding this comment.
I would use NULL as max value of the buffer.
As per Oracle doc, ENABLE(NULL) makes the buffer size unlimited.
There was a problem hiding this comment.
Great, I will remove the one with the size parameter, I think we don't need that anyways...
jgebal
approved these changes
Oct 26, 2017
jgebal
reviewed
Oct 26, 2017
| @@ -12,6 +12,8 @@ | |||
| */ | |||
| public final class DBHelper { | |||
|
|
|||
| public static final String UTPLSQL_VERSION = "3.0.3"; | |||
There was a problem hiding this comment.
This could be called: UTPLSQL_COMPATIBILITY_VERSION
jgebal
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ut_runer.runneeds to have DBMS_OUTPUT enabled #20