Code clean up

Author: simasch

.gitignore

@@ -3,5 +3,6 @@
 **/packages
 **/**/bin
 **/**/obj
-/.idea/
+**/.idea/
 **/**/*.nupkg
+**/utPLSQL.Api.sln.DotSettings.user

utPLSQL.Api/utPLSQL.Api.Test/RealTimeTestRunnerTest.cs

@@ -113,7 +113,7 @@ public void TestGetVersion()
 
             testRunner.Connect(username: "ut3_tester", password: "ut3", database: "orclpdb1");
 
-            string version = testRunner.GetVersion();
+            var version = testRunner.GetVersion();
 
             Assert.AreEqual("v3.1.11.3469-develop", version);
 
@@ -129,7 +129,7 @@ public void TestGetVersionWhenNotInstalled()
 
             try
             {
-                string version = testRunner.GetVersion();
+                var version = testRunner.GetVersion();
                 Assert.Fail();
             }
             catch (OracleException e)

utPLSQL.Api/utPLSQL.Api/RealTimeTestRunner.cs

@@ -17,10 +17,10 @@ public override async Task RunTestsAsync(List<string> paths, Action<@event> cons
         {
             if (paths != null && paths.Count > 0)
             {
-                string realtimeReporterId = Guid.NewGuid().ToString().Replace("-", "");
+                var realtimeReporterId = Guid.NewGuid().ToString().Replace("-", "");
 
-                Task taskRun = Task.Run(() => { UtRun(realtimeReporterId, paths); });
-                Task taskConsume = Task.Run(() => { ConsumeResult(realtimeReporterId, consumer); });
+                var taskRun = Task.Run(() => UtRun(realtimeReporterId, paths));
+                var taskConsume = Task.Run(() => ConsumeResult(realtimeReporterId, consumer));
 
                 await Task.WhenAll(taskRun, taskConsume);
             }
@@ -35,16 +35,16 @@ public override async Task<string> RunTestsWithCoverageAsync(List<string> paths,
         {
             if (paths != null && paths.Count > 0)
             {
-                string realtimeReporterId = Guid.NewGuid().ToString().Replace("-", "");
-                string coverageReporterId = Guid.NewGuid().ToString().Replace("-", "");
+                var realtimeReporterId = Guid.NewGuid().ToString().Replace("-", "");
+                var coverageReporterId = Guid.NewGuid().ToString().Replace("-", "");
 
-                Task taskRun = Task.Run(() => { UtRunWithCoverage(realtimeReporterId, coverageReporterId, paths, coverageSchemas, includeObjects, excludeObjects); });
-                Task taskConsume = Task.Run(() => { ConsumeResult(realtimeReporterId, consumer); });
-                Task<string> taskCoverateReport = Task.Run(() => { return GetCoverageReport(coverageReporterId); });
+                var taskRun = Task.Run(() => UtRunWithCoverage(realtimeReporterId, coverageReporterId, paths, coverageSchemas, includeObjects, excludeObjects));
+                var taskConsume = Task.Run(() => ConsumeResult(realtimeReporterId, consumer));
+                var taskCoverageReport = Task.Run(() => GetCoverageReport(coverageReporterId));
 
-                await Task.WhenAll(taskRun, taskConsume, taskCoverateReport);
+                await Task.WhenAll(taskRun, taskConsume, taskCoverageReport);
 
-                return taskCoverateReport.Result;
+                return taskCoverageReport.Result;
             }
             else
             {

utPLSQL.Api/utPLSQL.Api/TestRunner.cs

@@ -16,7 +16,7 @@ public abstract class TestRunner<T>
         internal OracleConnection produceConnection;
         internal OracleConnection consumeConnection;
 
-        protected List<OracleCommand> runningCommands = new List<OracleCommand>();
+        protected readonly List<OracleCommand> runningCommands = new List<OracleCommand>();
 
         /// <summary>
         /// Connects to the database. 
@@ -38,7 +38,7 @@ public void Connect(string username, string password, string database, string co
                 connectionString = $"User Id={username};DBA Privilege={connectAs};Password={password};Data Source={database}";
             }
 
-            foreach (OracleCommand command in runningCommands)
+            foreach (var command in runningCommands)
             {
                 command.Cancel();
             }
@@ -62,7 +62,7 @@ public void Close()
         /// Returns the installed utPLSQL version
         /// </summary>
         /// <returns>Version as string</returns>
-        public String GetVersion()
+        public string GetVersion()
         {
             var cmd = new OracleCommand("select ut.version() from dual", produceConnection);
             runningCommands.Add(cmd);
@@ -155,7 +155,7 @@ protected string GetCoverageReport(string id)
         protected string ConvertToUtVarchar2List(List<string> elements)
         {
             var sb = new StringBuilder();
-            bool first = true;
+            var first = true;
             foreach (var element in elements)
             {
                 if (!first)