-
Notifications
You must be signed in to change notification settings - Fork 238
Replace metrics with native Prometheus #35
Comments
If possible, can we continue to have the option to provide statsd metrics, at least for latency metrics. It's useful for us to ship these to our upstream metrics provider and do aggregation there, rather than in the application, like either prometheus or |
@idiamond-stripe yep, that's ok. Sticking to go-metrics with StatsD sounds ok then? I'd definitely still like to have native Prometheus metrics, and I think I'd probably rename a bunch of them/change what gets captured to be a little more useful. I'd love a PR to see what you've done so far (and take on to close this :) |
#114 should help replace a lot of the gRPC client/server boilerplate. I'd suggest therefore that we integrate #114 and then the focus of the changes in this issue would be around native prometheus metrics for the HTTP handler. Again, maybe there's a way we can just use the built in integrations to provide telemetry rather than recording/reporting within each of the handlers. The final thing we'd need to instrument would be timings around the |
This is addressed in #131- once that's merged we should have equivalent metrics captured. |
#131 has been merged! |
Given Prometheus as the standard means for collecting custom metrics within Kubernetes clusters, and the issues around exporting the go-metrics ones, it'd be prudent to overhaul and replace them with native prom equivalents.
I don't think we'd aim for naming parity so probably sensible to just replace according to the naming scheme the Prometheus authors recommend and fold into a major version release.
The text was updated successfully, but these errors were encountered: