Skip to content

Conversation

jurgenvinju
Copy link
Member

@jurgenvinju jurgenvinju commented Jul 7, 2023

This PR implements syntax role modifiers.

SyntaxModifiers.pdf

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Attention: Patch coverage is 28.73377% with 439 lines in your changes missing coverage. Please review.

Project coverage is 47%. Comparing base (71174c0) to head (c45eab9).

Files with missing lines Patch % Lines
src/org/rascalmpl/types/ModifySyntaxRole.java 23% 207 Missing and 28 partials ⚠️
src/org/rascalmpl/ast/SyntaxRoleModifier.java 20% 90 Missing and 1 partial ⚠️
src/org/rascalmpl/library/Type.java 33% 24 Missing ⚠️
src/org/rascalmpl/ast/Type.java 34% 20 Missing and 1 partial ⚠️
src/org/rascalmpl/types/RascalTypeFactory.java 43% 12 Missing and 1 partial ⚠️
...ascalmpl/semantics/dynamic/SyntaxRoleModifier.java 55% 12 Missing ⚠️
...org/rascalmpl/values/parsetrees/SymbolFactory.java 35% 10 Missing and 1 partial ⚠️
src/org/rascalmpl/ast/NullASTVisitor.java 0% 6 Missing ⚠️
src/org/rascalmpl/types/RascalType.java 0% 6 Missing ⚠️
src/org/rascalmpl/runtime/$RascalModule.java 0% 5 Missing ⚠️
... and 9 more
Additional details and impacted files
@@           Coverage Diff            @@
##              main   #1835    +/-   ##
========================================
- Coverage       47%     47%    -1%     
- Complexity    6342    6385    +43     
========================================
  Files          764     767     +3     
  Lines        63177   63808   +631     
  Branches      9431    9541   +110     
========================================
+ Hits         29945   30191   +246     
- Misses       31010   31373   +363     
- Partials      2222    2244    +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…l) returns false via @DavyLandman for the equals contract on null
…s by calling the RascalTypeFactory and recursion on the single type parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants