Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose to de-escalate double constructor declaration warning to info #1788

Closed
jurgenvinju opened this issue Apr 12, 2023 · 2 comments
Closed
Assignees

Comments

@jurgenvinju
Copy link
Member

Describe the bug

image

It is normal to have constructors with the same names but for different types in the same namespace. This warning makes it seem like a problem, but the typechecker itself is the way out of the problem because it will ask for a disambiguation at the call site.

I really do not want to rename these constructors since this is the same concept modeled in another tier of language model. One is the syntax of the type names (Type), and the other is their symbolic representation for computing with types (TypeSymbol).

If we de-escalate this to an "info" message we get the same information but without the urge to have to fix it.

Copy link
Member

Yes makes sense, downgraded to info and made message more helpful.

Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants