Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify IO module by using keyword fields with defaults instead of overloaded alternatives #1681

Closed
jurgenvinju opened this issue Oct 21, 2022 · 4 comments
Closed

simplify IO module by using keyword fields with defaults instead of overloaded alternatives #1681

jurgenvinju opened this issue Oct 21, 2022 · 4 comments
Labels
enhancement

Comments

@jurgenvinju
Copy link
Member

Describe the bug

  • readFile
  • readFileEnc
  • readFileLines
  • readFileLinesEnc
  • writeFile
  • writeFileEnc

could be 3 functions instead of 6.
@DavyLandman
Copy link
Member

Yes! Great idea

@jurgenvinju
Copy link
Member Author

is this one of those @deprecated situations? I guess so. So I'll add the encoding keyword parameters and @deprecate the other functions.

@DavyLandman
Copy link
Member

yup, and just have those functions call the new functions in their body? That way we can reduce the size of prelude, and show people how to rewrite the deprecated functions.

@jurgenvinju
Copy link
Member Author

o that's a good one.

@jurgenvinju jurgenvinju mentioned this issue Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavyLandman @jurgenvinju