Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets client #399

Open
apolukhin opened this issue Oct 25, 2023 · 3 comments
Open

Websockets client #399

apolukhin opened this issue Oct 25, 2023 · 3 comments
Labels
big A big feature help wanted We would appreciate PR

Comments

@apolukhin
Copy link
Member

Make sure that the HTTP Client is usable for websockets, add the missing functionality if it is not. Add tests.

Internal ticket: 7503

@apolukhin apolukhin added help wanted We would appreciate PR big A big feature labels Oct 25, 2023
@Turim
Copy link
Contributor

Turim commented Jul 17, 2024

I'm not sure what's the topic. Is it either Websocket readiness itself or Websocket vs (idk) Http Client compatibility?

Imo it looks good (it basically works (e.g. explicitly tested by wscat). it works even with TLS), but it lacks flexibility, which clients may intend to develop themselves. For instance, it supposed to be bi-directional, but currently (meaning github's v2.[1-2]) client should reinvent the wheel and re-write it to some extent deeply, e.g. switching to (other wrappers around) non-blocking recv().

May be I'd have written some proposal , but I can't figure out the merge policy. I have seen several approved PRs, which hasn't been merged yet. From this PoV it looks like dead-PRs/dead code (=> time waste).

upd. still applicable to 2.2 though.

upd2. Some flexibility have been added, tnx #661

@Turim
Copy link
Contributor

Turim commented Aug 13, 2024

Actually today there are some tests, samples (but, frankly speaking, I expected full duplex to be present in samples also).

Is the issue relevant still?

@apolukhin
Copy link
Member Author

The issues is relevant: we have samples for websockets server, but there's no example of how to create a websocket connection from userver (C++ code) to the websocket server.

I expected full duplex to be present in samples also
Yes, This should be done some day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big A big feature help wanted We would appreciate PR
Projects
None yet
Development

No branches or pull requests

2 participants